Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add DCO #6048

Merged
merged 2 commits into from
Oct 29, 2024
Merged

docs: Add DCO #6048

merged 2 commits into from
Oct 29, 2024

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon requested a review from a team October 13, 2024 12:43
@UlisesGascon UlisesGascon self-assigned this Oct 13, 2024
@UlisesGascon
Copy link
Member Author

ping: @expressjs/express-tc

@bjohansebas
Copy link
Member

It could be added as a comment in the PR messages like pkgjs does.

ref: https://github.com/pkgjs/.github/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1

@UlisesGascon
Copy link
Member Author

Great idea @bjohansebas. Would you mind to do a PR for that? :)

Contributing.md Outdated Show resolved Hide resolved
Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
@UlisesGascon UlisesGascon merged commit b31910c into master Oct 29, 2024
2 checks passed
@UlisesGascon UlisesGascon changed the title Add DCO docs: Add DCO Oct 29, 2024
@UlisesGascon UlisesGascon deleted the ulises/DCO branch October 29, 2024 12:35
@UlisesGascon UlisesGascon mentioned this pull request Oct 29, 2024
ljharb added a commit to ljharb/nvm that referenced this pull request Nov 5, 2024
imo this shouldn‘t be necessary, as it should be implied by the act of making a PR.

Following the example in expressjs/express#6048

See openjs-foundation/project-status#2
ljharb added a commit to ljharb/nvm that referenced this pull request Nov 5, 2024
imo this shouldn‘t be necessary, as it should be implied by the act of making a PR.

Following the example in expressjs/express#6048

See openjs-foundation/project-status#2
ljharb added a commit to ljharb/nvm that referenced this pull request Nov 5, 2024
imo this shouldn‘t be necessary, as it should be implied by the act of making a PR.

Following the example in expressjs/express#6048

See openjs-foundation/project-status#2
@ljharb ljharb mentioned this pull request Nov 5, 2024
ljharb added a commit to ljharb/nvm that referenced this pull request Nov 5, 2024
imo this shouldn‘t be necessary, as it should be implied by the act of making a PR.

Following the example in expressjs/express#6048

See openjs-foundation/project-status#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants