Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a loop here would improve performance for parsing over splitting into an array and iterating over it, then splitting some more. If we prefer the overall split on
;
for readability though, we can still avoid the second split by usingindexOf
instead. There's also some slices andtrim
that could be avoided for extra performance but it seemed a little overkill for this function.Finally, given the code is only used here:
express/lib/response.js
Lines 575 to 584 in a46cfdc
value
only and avoid the rest of the processing entirely.closes https://github.com/expressjs/security-triage/issues/24