-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring from jQuery to modern JavaScript #1590
Comments
The search bar in dark mode is broken in terms of design. @chrisdel101 Should I fix it in the first PR or better in a separate PR? |
I'm just looking at #1590 since I think you fixed it over there right? Sorry |
@chrisdel101 don't worry, that issue is not fixed yet. |
Oh is this a different issue? I see. Maybe a small separeate PR would work, but things are getting kind of backed up. Still, it's not really related to the refactor, so separate issue would be my vote. |
* feat: drop dropi * fix theme position * merge menu.css to style.css * remove unused class * improve menu styles * fix dark mode * remove padding in logo * add support lts link * adapt headers in other langs * adapt other langs * revert remove ismobile.js * improve styles * fix dark mode subcontent * fix translate subcontent * fix dark mode in mobile * fix nav space * fix errors in chrome * small styles * add optional chaining * small changes * improve submenu logic * remove some !important * remove some !important * fix hover * Revert "add optional chaining" This reverts commit f3e40af. * fix mobile detect * small fix * remove $ * update style.css * improve layout
* feat: drop dropi * fix theme position * merge menu.css to style.css * remove unused class * improve menu styles * fix dark mode * remove padding in logo * add support lts link * adapt headers in other langs * adapt other langs * revert remove ismobile.js * improve styles * fix dark mode subcontent * fix translate subcontent * fix dark mode in mobile * fix nav space * fix errors in chrome * small styles * add optional chaining * small changes * improve submenu logic * remove some !important * remove some !important * fix hover * Revert "add optional chaining" This reverts commit f3e40af. * fix mobile detect * small fix * remove $ * update style.css * improve layout
As discussed in #1568, these will be the next steps to stop using jQuery in favor of the browser's API:
First PR (Refactor Menu): new design and logic for the menu #1590 #1568
Second PR (Remove Unused Functions): feat: remove unused functions (#1590) #1698
window.location.pathname === '/3x/api.html'
(no longer used since almost all URLs now go to/en/*
)#tags-side-menu
Third PR (Adapt get elements):
Fourth PR (Adapt Functions):
Fifth PR (Remove jQuery Dependency, Remove jQuery #1569):
The text was updated successfully, but these errors were encountered: