Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring from jQuery to modern JavaScript #1590

Open
1 of 5 tasks
bjohansebas opened this issue Sep 2, 2024 · 4 comments
Open
1 of 5 tasks

refactoring from jQuery to modern JavaScript #1590

bjohansebas opened this issue Sep 2, 2024 · 4 comments
Assignees
Labels
UI Change, update, or fix for site UI (not content)

Comments

@bjohansebas
Copy link
Member

bjohansebas commented Sep 2, 2024

As discussed in #1568, these will be the next steps to stop using jQuery in favor of the browser's API:

  • First PR (Refactor Menu): new design and logic for the menu #1590 #1568

    • Remove dropit
    • Remove functions related to dropit
    • Refactor the menu according to the new structure
    • Create styles according to the new structure
    • Add new menu functionality in a new file
  • Second PR (Remove Unused Functions): feat: remove unused functions (#1590) #1698

  • Third PR (Adapt get elements):

    • Update scroll top logic
    • Adapt element retrieval and events
    • Add overlay logic to the menu
    • Adapt code highlighting
  • Fourth PR (Adapt Functions):

    • Update logic for the i18n banner
    • Update logic for the closer title (used in the API)
    • Adapt cookies logic to ES6
  • Fifth PR (Remove jQuery Dependency, Remove jQuery  #1569):

    • Remove link to jQuery
@bjohansebas bjohansebas added the UI Change, update, or fix for site UI (not content) label Sep 2, 2024
@bjohansebas bjohansebas self-assigned this Sep 2, 2024
@bjohansebas
Copy link
Member Author

The search bar in dark mode is broken in terms of design. @chrisdel101 Should I fix it in the first PR or better in a separate PR?

image

@chrisdel101
Copy link
Contributor

I'm just looking at #1590 since I think you fixed it over there right? Sorry
for delay.

@bjohansebas
Copy link
Member Author

@chrisdel101 don't worry, that issue is not fixed yet.

@chrisdel101
Copy link
Contributor

Oh is this a different issue? I see. Maybe a small separeate PR would work, but things are getting kind of backed up. Still, it's not really related to the refactor, so separate issue would be my vote.

bjohansebas added a commit that referenced this issue Oct 29, 2024
* feat: drop dropi

* fix theme position

* merge menu.css to style.css

* remove unused class

* improve menu styles

* fix dark mode

* remove padding in logo

* add support lts link

* adapt headers in other langs

* adapt other langs

* revert remove ismobile.js

* improve styles

* fix dark mode subcontent

* fix translate subcontent

* fix dark mode in mobile

* fix nav space

* fix errors in chrome

* small styles

* add optional chaining

* small changes

* improve submenu logic

* remove some !important

* remove some !important

* fix hover

* Revert "add optional chaining"

This reverts commit f3e40af.

* fix mobile detect

* small fix

* remove $

* update style.css

* improve layout
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this issue Nov 3, 2024
* feat: drop dropi

* fix theme position

* merge menu.css to style.css

* remove unused class

* improve menu styles

* fix dark mode

* remove padding in logo

* add support lts link

* adapt headers in other langs

* adapt other langs

* revert remove ismobile.js

* improve styles

* fix dark mode subcontent

* fix translate subcontent

* fix dark mode in mobile

* fix nav space

* fix errors in chrome

* small styles

* add optional chaining

* small changes

* improve submenu logic

* remove some !important

* remove some !important

* fix hover

* Revert "add optional chaining"

This reverts commit f3e40af.

* fix mobile detect

* small fix

* remove $

* update style.css

* improve layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Change, update, or fix for site UI (not content)
Projects
None yet
Development

No branches or pull requests

2 participants