Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document path to regexp migration #1317

Conversation

euoia
Copy link
Contributor

@euoia euoia commented Jan 5, 2022

Add documentation based on the updates to path-to-regexp in https://github.com/pillarjs/router/pull/102/files.

I also took the opportunity to simplify the intro and remove references to "alpha". I'm happy to revert or extract these to a separate pull request if it's more appropriate.

@euoia
Copy link
Contributor Author

euoia commented Jan 5, 2022

See the original version of this pull request if you need more context: #1316

@euoia
Copy link
Contributor Author

euoia commented Jan 5, 2022

@dougwilson @crandmck The migration guide is translated into other languages. Can you let me know the process for handling the translated versions?

@dougwilson
Copy link
Contributor

Hi @euoia sorry for the delay. I will take a read through this, but first just wanted to respond to your question:

Translation is now only handled by community members who lend a hand; we no longer have a professional translation service. If the English page changes enough to make the translated page misleading or such, we can just delete it so that lanage sees the English version until someone translates it again.

@dougwilson dougwilson added the pr label Jan 7, 2022
@dougwilson dougwilson force-pushed the gh-pages branch 2 times, most recently from 1fd61c6 to ef068f8 Compare February 18, 2022 03:09
@crandmck crandmck added the needs tech review A doc edit that requires technical review before merging label Mar 6, 2024
@crandmck
Copy link
Member

crandmck commented Apr 26, 2024

Something very similar was done in https://expressjs.com/en/guide/migrating-5.html so this probably isn't needed any more.

The only diff is that this has

npm install --save express@>=5.0.0

And we currently have

npm install "express@>=5.0.0-beta.1" --save

In practice, I think they're equivalent, but I'm no expert on npm versioning expressions.
@jonchurch Do you think one is better than the other?

@jonchurch
Copy link
Member

cc @blakeembrey, is this accurate so far as you know?

@blakeembrey
Copy link
Member

@jonchurch Accurate, although I intend to re-add * back before we do the Express.js 5 release. Also, we could land the regex matching group feature in express 4 when we merge expressjs/express#5603.

@crandmck
Copy link
Member

crandmck commented May 4, 2024

Sorry to be dense, but can you clarify which you prefer for "Upgrading to 5.x" in the doc?

  • The version as specified in this PR express@>=5.0.0-beta.1
  • What we have now express@>=5.0.0
  • Either is OK

bjohansebas added a commit to bjohansebas/expressjs.com-fork that referenced this pull request Sep 14, 2024
@bjohansebas
Copy link
Member

Closed in favor of #1610

UlisesGascon pushed a commit that referenced this pull request Oct 6, 2024
* add `res.query` and `res.redirect`
* add `express.urlencoded` and `req.body`
* add `res.clearCookie` and `res.status`
* update introduction page
* add `res.redirect('back')` and `res.location('back')`
* bring changes from #1317
* add `brotli` support
* adapt router matching syntax
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 3, 2024
* add `res.query` and `res.redirect`
* add `express.urlencoded` and `req.body`
* add `res.clearCookie` and `res.status`
* update introduction page
* add `res.redirect('back')` and `res.location('back')`
* bring changes from expressjs#1317
* add `brotli` support
* adapt router matching syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tech review A doc edit that requires technical review before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants