feat: improve footer layout #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
It feels much modern and fresh! Thanks for the proposal @bjohansebas! One question... should the OpenJS logo be in the center in mobile?
|
|
@UlisesGascon yes, it should be centered; it’s fixed now.
|
|
LGTM @bjohansebas This highlights the need to separate layout from content, so changes like this wouldn't require modifying every language, but that's another story! |
|
@crandmck Ready, the new footer is now available in the other languages. |
UlisesGascon
approved these changes
Aug 1, 2024
|
Thanks @bjohansebas ! |
chrisdel101
pushed a commit
to chrisdel101/expressjs.com
that referenced
this pull request
Nov 3, 2024
* feat: improve footer layout * feat: add new links of openjs policy * feat: center openjsf logo in mobil * feat: improve footer in other languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: