-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve admonitions notes #1549
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @bjohansebas in general, this looks good. These things are typically called "admonitions" not "asides". Could you change the directory to that just for sake of conforming to industry standards. Also, this is a fairly sweeping change and I didn't have time to review it in depth yet. Maybe @chrisdel101 or @inigomarquinez can help on that front. |
The code changes look fine to me. I didn't go through every single page in preview but the ones I did see look pretty nice! |
@crandmck @chrisdel101 thanks for the recommendation; the directory name change has been made. |
I'll land this, but would like to understand why the |
* feat: change color of aside notes * rename aside dir to admonitions
Colors have been changed because their meanings were not visually distinguishable, making the documentation difficult to read. Additionally, in dark mode, the colors were not displayed correctly.
Notice:
Note:
Warn: