Using variable to display the version in migration guide for 5 #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The check translation action throwing an error saying, RequestError [HttpError]: Resource not accessible by integrationI am guessing this has something to do with the action itself as nothing else than the required md files and |
|
Yes @IamLizu! Seems like there is an issue with GitHub actions regarding HTTP requests that is not related to this change, we can ignore that CI check. |
crandmck
approved these changes
Aug 5, 2024
|
Thanks @IamLizu ! |
chrisdel101
pushed a commit
to chrisdel101/expressjs.com
that referenced
this pull request
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @crandmck suggested in expressjs/expressjs.com#1464, we need a better way to address the version change in the long run.
I have kept a variable in
_data/express.ymlas suggested and referenced that variable in the hardcoded npm command in all available language pages.There was a formatting issue at ko lang, basically removed unnecessary script declaration to fix that.
Notes