Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permissions for translation workflow #1642

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

bjohansebas
Copy link
Member

This should fix the workflow for people who do not have write permissions by adding a new custom token

The requested token should have the following permissions:

permissions:
  contents: read
  pull-requests: write
  issues: write

ref: https://github.com/actions/github-script/tree/v7?tab=readme-ov-file#using-a-separate-github-token

close: #1553

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 8af8c0f
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/670067704021f00008528d6e
😎 Deploy Preview https://deploy-preview-1642--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas bjohansebas changed the title set new token fix permissions for translation workflow Oct 4, 2024
@IamLizu
Copy link
Member

IamLizu commented Oct 4, 2024

Yes, using a PAT will indeed fix the problem as I was saying here in #1553 (comment). I was waiting for someone to come up with another solution other than using PAT. As I already had a branch (unpushed) using PAT.

I had also reached @UlisesGascon in slack (in August 😄) to create a PAT but perhaps the message was somehow unnoticed.

Anyways, we will need to create that token in the repo settings now and it should work.

@bjohansebas
Copy link
Member Author

@IamLizu Sorry, the issue had gotten so long that I didn't remember you had that PR ready.

@IamLizu
Copy link
Member

IamLizu commented Oct 4, 2024

Hey @bjohansebas 👋

No worries 🎉

Copy link
Member

@crandmck crandmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been needed for a while, thanks!
I'm not really up to speed on GH tokens or workflow--do we need to do anything else to make this work? Or just land this PR?

Copy link
Member

@IamLizu IamLizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@crandmck we need to create that PAT referenced in the workflow for this to work.

@bjohansebas
Copy link
Member Author

@UlisesGascon can you help us with this? I don't have enough permissions to add the PAT.

@UlisesGascon
Copy link
Member

I will configure the PAT, ideally we can use a PAT that is part of the organization settings and not from the maintainers as individuals. based on this seems feasible. I will try it soon (today/tomorrow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"RequestError [HttpError]: Resource not accessible by integration" for .github/workflows /translation.yml
5 participants