-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix permissions for translation workflow #1642
base: gh-pages
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Yes, using a PAT will indeed fix the problem as I was saying here in #1553 (comment). I was waiting for someone to come up with another solution other than using PAT. As I already had a branch (unpushed) using PAT. I had also reached @UlisesGascon in slack (in August 😄) to create a PAT but perhaps the message was somehow unnoticed. Anyways, we will need to create that token in the repo settings now and it should work. |
@IamLizu Sorry, the issue had gotten so long that I didn't remember you had that PR ready. |
Hey @bjohansebas 👋 No worries 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been needed for a while, thanks!
I'm not really up to speed on GH tokens or workflow--do we need to do anything else to make this work? Or just land this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
@crandmck we need to create that PAT referenced in the workflow for this to work.
@UlisesGascon can you help us with this? I don't have enough permissions to add the PAT. |
I will configure the PAT, ideally we can use a PAT that is part of the organization settings and not from the maintainers as individuals. based on this seems feasible. I will try it soon (today/tomorrow) |
This should fix the workflow for people who do not have write permissions by adding a new custom token
The requested token should have the following permissions:
ref: https://github.com/actions/github-script/tree/v7?tab=readme-ov-file#using-a-separate-github-token
close: #1553