Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/adjust in home poc #1706

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

carlosstenzel
Copy link
Contributor

@carlosstenzel carlosstenzel commented Dec 4, 2024

Testing changes to the structure of the home page

Before:
Captura de Tela 2024-12-04 às 09 44 53

After:
Captura de Tela 2024-12-04 às 09 45 15

** I made the changes only in the pt-br language just to illustrate

LINK PREVIEW IN PT-BR https://deploy-preview-1706--expressjscom-preview.netlify.app/pt-br/

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit d17ac56
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/67504f51f876c00008ef2419
😎 Deploy Preview https://deploy-preview-1706--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas
Copy link
Member

I like it, I don't think we should add the quick example title.

<div id="middleware" class="feature-box">
<h3>Middleware</h3>
<p>Estenda as funcionalidades do Express através de middleware. Desde autenticação até compressão, existe um middleware para cada necessidade da sua aplicação.</p>
<a href="{{ page.lang }}/guide/using-middleware.html" class="learn-more">Saiba mais →</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was always this 404, it's time to fix it.

Suggested change
<a href="{{ page.lang }}/guide/using-middleware.html" class="learn-more">Saiba mais →</a>
<a href="/{{ page.lang }}/guide/using-middleware.html" class="learn-more">Saiba mais →</a>

<div id="quick-start">
<h4>Exemplo Rápido</h4>
<pre><code class="language-javascript">
const express = require('express')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's time to promote ESM?

cc: @expressjs/express-tc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants