Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create docs folder under the root folder #16

Merged
merged 3 commits into from
Apr 10, 2024
Merged

chore: create docs folder under the root folder #16

merged 3 commits into from
Apr 10, 2024

Conversation

inigomarquinez
Copy link
Member

The objective of this PR is to have a docs folder under the root folder for all the files related to documentation.

Before it was under the /tools folder, which didn't make too much sense.

Apart from that, the packages-in-scope.md file has also been moved from /tools/scope to this new /docs folder.

@inigomarquinez inigomarquinez self-assigned this Apr 9, 2024
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon
Copy link
Member

UlisesGascon commented Apr 9, 2024

Additionally we will need to update:

As the reference have changed :)

@inigomarquinez
Copy link
Member Author

Additionally we will need to update:

As the reference have changed :)

@UlisesGascon do I create the PRs or do I wait until this PR is merged?

@UlisesGascon
Copy link
Member

do I create the PRs or do I wait until this PR is merged?

Feel free to create them, so we will merge queue them

@inigomarquinez
Copy link
Member Author

@UlisesGascon

I've already created a PR to update the reference to the Thread Model in the express documentation and I've modified this same PR to fix the location of the packages-in-scope.md file.

@UlisesGascon UlisesGascon merged commit 583126f into expressjs:main Apr 10, 2024
@inigomarquinez inigomarquinez deleted the move-docs branch April 11, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants