Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update debug due to security issue #65

Closed
wants to merge 8 commits into from
Closed

deps: Update debug due to security issue #65

wants to merge 8 commits into from

Conversation

danez
Copy link
Contributor

@danez danez commented Sep 28, 2017

Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to version 2.6.9

@dougwilson
Copy link
Contributor

Also, need an entry in the changelog.

@danez
Copy link
Contributor Author

danez commented Sep 28, 2017

Ok changed

Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the version number, as I can't run release scripts with it there. Also, it would assume this is the only change for the patch version.

As for the sub text, that should only state what users will notice from the change. Does this module use the %o formatter and/or expose it to them at all?

@dougwilson
Copy link
Contributor

Here is an example of previous commits: 53a7b06 if it helps :)

@danez
Copy link
Contributor Author

danez commented Sep 28, 2017

Okay removed the version. For the other question I don't know, I haven't cloned or looked at the code. But as long as the version is updated it doesn't really matter I guess.

@dougwilson
Copy link
Contributor

Just remove that sub bullet, then.

@danez
Copy link
Contributor Author

danez commented Sep 28, 2017

okay thanks.

@dougwilson
Copy link
Contributor

I will merge this later today after the Express 4.16 release, as changes here takes away from the CI resources Express.js needs. The number of commits here has sadly created a 30 minute backlog on AppVeyor so Express will be delayed 30 minutes :(

@danez
Copy link
Contributor Author

danez commented Sep 28, 2017

Can't you cancel them? I'm sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants