Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Partitioned" option to cookies #966

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

alexop1000
Copy link
Contributor

closes #961

@cattermo
Copy link

cattermo commented Jan 5, 2024

@dougwilson Can we please merge and release this 🙏

@kaulshashank
Copy link

+1

@sergioRozenszajn
Copy link

Hi,
While discussing this flow we have been requested that the partition property addition would be agent dependent. This requirement comes because some old browsers/browser versions might break if an un-expected cookie property is provided.
We have tried to modify the JSession cookie dynamically, after it was generated, with no success. Express-session will then generate another cookie.
Would you consider to support a more dynamic behavior? --> for example to provide a callback function to modify JSessionID cookie properties on cookie creation.

@kaulshashank
Copy link

Would you consider to support a more dynamic behavior? --> for example to provide a callback function to modify JSessionID cookie properties on cookie creation.

Can we also get an explicit way to set this particular cookie like it is done in this PR? Not everyone may want to do a UA check.

@dougwilson dougwilson merged commit 5d17063 into expressjs:master Jan 28, 2024
26 checks passed
dougwilson pushed a commit that referenced this pull request Jan 28, 2024
dougwilson pushed a commit that referenced this pull request Jan 28, 2024
dougwilson pushed a commit that referenced this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support of phasing out third-party cookies
5 participants