Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/unit test #195

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Test/unit test #195

merged 2 commits into from
Nov 20, 2024

Conversation

juliano-soares
Copy link
Member

@juliano-soares juliano-soares commented Nov 20, 2024

Pull Request Guidelines

Our guidelines for submitting a pull request.

Before submitting a Pull Request, please make sure you have verified the following:

  • The commit message follows our guidelines:
    • A good commit message should be two things: meaningful and concise. It should not contain every single detail, describing each changed line—we can see all the changes in Git—but, at the same time, it should say enough to avoid ambiguity.
    • We use Microverse's commit message convention
    • The convention stablish that a commit message has to be in the present tense, imperative and lowercase.
    • Example: fix typo in README.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Tests

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

What is the new behavior?

Describe the new behavior or link to a relevant issue.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.

Other information

Any other information that is important to this PR.

@juliano-soares juliano-soares self-assigned this Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.97%. Comparing base (fd2551e) to head (5be0404).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #195       +/-   ##
===========================================
+ Coverage   24.28%   53.97%   +29.68%     
===========================================
  Files          18       18               
  Lines         704      704               
  Branches      169      167        -2     
===========================================
+ Hits          171      380      +209     
+ Misses        533      304      -229     
- Partials        0       20       +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rsaz rsaz added enhancement New feature or request test Tests labels Nov 20, 2024
@rsaz rsaz merged commit ad26682 into main Nov 20, 2024
7 checks passed
@rsaz rsaz deleted the test/unit-test branch November 20, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Tests
Projects
Development

Successfully merging this pull request may close these issues.

2 participants