Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment provider can not use \Extcode\Cart\EventListener\Order\Finish\Email #605

Closed
extcode opened this issue Dec 11, 2024 · 1 comment
Closed
Assignees
Labels
9.x related to TYPO3 v12 10.x related to TYPO3 v13

Comments

@extcode
Copy link
Owner

extcode commented Dec 11, 2024

Bug Report

Current Behavior
A payment provider can have its own order finish event to complete the order after a successful payment action. For certain reasons, this event can then use other EventListeners than those registered for the cart extension event. However, to avoid having to build a separate email handling for each payment provider, it would be nice if you could register the existing order finish email event listener for the order finish event of the payment provider extension. However, this leads to an error in TYPO3 v12 and v13, as the EventInterface has been replaced with concrete events. However, the EventListener only needs a class that implements the EventInterface.

Expected behavior/output
The EventListener can be used again.

Environment

  • TYPO3 version(s): 12.4 and 13.4
  • cart version: 9.x and 10.x

Possible Solution
The three EventListeners

  • \Extcode\Cart\EventListener\Order\Create\Order
  • \Extcode\Cart\EventListener\Order\Finish\ClearCart
  • \Extcode\Cart\EventListener\Order\Finish\Email

should use the interface in the __invoke() method as in TYPO3 v11.

@extcode extcode added 9.x related to TYPO3 v12 10.x related to TYPO3 v13 labels Dec 11, 2024
@extcode extcode self-assigned this Dec 11, 2024
extcode added a commit that referenced this issue Dec 11, 2024
extcode added a commit that referenced this issue Dec 11, 2024
@extcode extcode closed this as completed Dec 11, 2024
@rintisch
Copy link
Collaborator

Sorry :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.x related to TYPO3 v12 10.x related to TYPO3 v13
Projects
None yet
Development

No branches or pull requests

2 participants