Add function signature attributes #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detection
`cargo doc`.
`cargo doc`
|
Could you separate each change to its own PR? |
|
Why? They are very minute. I see now I accidentally committed something unnecessary... |
|
Because we cannot track which one of your changes would affect what part of the bindings. |
|
Closing this in favour of #177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various updates that I wanted to put together, mainly:
enable-function-attribute-detectionthat should address the-> !, issue, see https://ferrous-systems.com/blog/bindgen/.cargo docwarningsbindgento ensure that we follow the progress thereI've tried to do more with bindings, and I've semi-successful MVPs, but they are not ready for
libR-sys.