update use_msrv to fix test and add optional overwrite argument

NAMESPACE

@@ -23,6 +23,7 @@ export(to_toml)
 export(use_cran_defaults)
 export(use_crate)
 export(use_extendr)
+export(use_msrv)
 export(vendor_pkgs)
 export(write_license_note)
 importFrom(dplyr,"%>%")

R/use_msrv.R

@@ -2,9 +2,9 @@
 #'
 #' `use_msrv()` sets the minimum supported rust version for your R package.
 #'
-#' @param version character scalar, the minimum supported Rust version
-#' @param path character scalar, path to folder containing DESCRIPTION file
-#'
+#' @param version character scalar, the minimum supported Rust version.
+#' @param path character scalar, path to folder containing DESCRIPTION file.
+#' @param overwrite default `FALSE`. Overwrites the `SystemRequirements` field if already set when `TRUE`.
 #' @details
 #'
 #' The minimum supported rust version (MSRV) is determined by the
@@ -38,13 +38,11 @@
 #' use_msrv("1.67.1")
 #' }
 #'
-use_msrv <- function(version, path = ".") {
-  if (length(version) != 1L) {
-    cli::cli_abort(
-      "Version must be a character scalar",
-      class = "rextendr_error"
-    )
-  }
+use_msrv <- function(version, path = ".", overwrite = FALSE) {
+
+  check_string(version, class = "rextendr_error")
+  check_string(path, class = "rextendr_error")
+  check_bool(overwrite, class = "rextendr_error")
 
   msrv_call <- rlang::caller_call()
   version <- tryCatch(numeric_version(version), error = function(e) {
@@ -68,10 +66,12 @@ use_msrv <- function(version, path = ".") {
 
   prev <- desc::desc_get("SystemRequirements", file = desc_path)[[1]]
   prev <- stringi::stri_trim_both(prev)
+  prev_is_default <- identical(prev, "Cargo (Rust's package manager), rustc")
 
-  if (is.na(prev)) {
+  # if it isn't set update the description or if overwrite is true
+  if (is.na(prev) || overwrite || prev_is_default) {
     update_description("SystemRequirements", cur, desc_path = desc_path)
-  } else if (!identical(cur, prev)) {
+  } else if (!identical(cur, prev) && !overwrite) {
     cli::cli_ul(
       c(
         "The SystemRequirements field in the {.file DESCRIPTION} file is
@@ -80,7 +80,7 @@ use_msrv <- function(version, path = ".") {
         "{.code SystemRequirements: {cur}}"
       )
     )
-  }
+  } 
 
   invisible(version)
 }

tests/testthat/test-use_msrv.R

@@ -1,13 +1,18 @@
 test_that("use_msrv() modifies the MSRV in the DESCRIPTION", {
   skip_if_not_installed("usethis")
 
-  path <- withr::local_package("testpkg")
+  path <- local_package("testpkg")
 
   # capture setup messages
   withr::local_options(usethis.quiet = FALSE)
 
   use_extendr(path, quiet = TRUE)
-  use_msrv("1.70")
+  use_msrv("1.70", path)
 
-  expect_snapshot(cat(readLines("DESCRIPTION"), sep = "\n"))
-})
+  d <- desc::desc("DESCRIPTION")
+
+  expect_identical(
+    "Cargo (Rust's package manager), rustc >= 1.70",
+    d$get_field("SystemRequirements")
+  )
+})