refactor(test): replace mockr to testthat's mock functions #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
changed the title
mockr::local_mock -> testthat::local_mocked-bindingsmockr::local_mock -> testthat::local_mocked_bindings
eitsupi
changed the title
mockr::local_mock -> testthat::local_mocked_bindings
Ilia-Kosenkov
approved these changes
Jun 26, 2023
|
Sorry, I forgot to bump the version of testthat. |
|
I forgot, can you merge it yourself after approval? |
|
I do not have merge rights to this repository, so cannot merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testthat now have the new mocking tools (r-lib/testthat#1739).
So, the mockr package is no longer needed.