Fix linter complaints #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Ilia-Kosenkov
commented
Aug 3, 2024
•
Ilia-Kosenkov
commented
- Fix spelling errors
- Refactor type checking code
|
I don't understand some of these changes... Why did you change that one function that had a |
JosiahParry
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
I don't understand some of these changes... Why did you change that one function that had a
lengthparameter?
This is just rearranging the internals of the function. I had similar qualms about defining a function inside of a function—just never took it upon myself to fix it. The change is purely cosmetic!
These look good and address long standing typos as well!
|
Was that the auto-merger?! That was fast :P |
|
Yep, just refactoring. Extracted inner functions as they introduced too much complexity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.