-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use_msrv() #384
use_msrv() #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on discord, I think there could be more details on the relationship between the MSRV and the CRAN version. Here are a couple of comments, I hope it helps
Co-authored-by: Josiah Parry <josiah.parry@gmail.com>
Co-authored-by: Josiah Parry <josiah.parry@gmail.com>
Co-authored-by: Josiah Parry <josiah.parry@gmail.com>
Co-authored-by: Josiah Parry <josiah.parry@gmail.com>
Co-authored-by: Josiah Parry <josiah.parry@gmail.com>
Co-authored-by: Josiah Parry <josiah.parry@gmail.com>
Co-authored-by: Josiah Parry <josiah.parry@gmail.com>
I think the last thing that this needs is a snapshot test. Do you think you can do that? For example the test would be created using test_that("use_msrv() modifies the MSRV in the DESCRIPTION", {
skip_if_not_installed("usethis")
path <- local_package("testpkg")
# capture setup messages
withr::local_options(usethis.quiet = FALSE)
use_extendr(path, quiet = TRUE)
use_msrv("1.70")
expect_snapshot(cat_file("DESCRIPTION"))
}) |
Assuming the linter is finally satisfied this is ready to be merged! |
@JosiahParry Coming a bit late after this got merged but could you include the table you published on Mastodon about the R version and platforms on CRAN and the associated Rust version? I think it would fit either in the doc of this function or in the vignette about CRAN |
I think the problem with that is that we don't know when the rust versions will change and it may be that the table is out of date already. I did make an issue for the extendr website to report the CRAN versions which I think would be a more appropriate place for them extendr/extendr.github.io#40 |
Yes, I see the problem of this getting outdated. It could be that a simple CI script runs weekly to update it. But anyway, I just wanted to be sure this was tracked somewhere :) |
We ought to add a |
This enables setting MSRV in DESCRIPTION
SystemRequirements
from R.It is part of the push for a CRAN release: #362.