Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing headers in SendRequest #84

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix writing headers in SendRequest #84

merged 1 commit into from
May 22, 2024

Conversation

bradyjoslin
Copy link
Contributor

Closes #83

@nilslice nilslice requested a review from mhmd-azeez May 22, 2024 05:30
@nilslice nilslice added bug Something isn't working enhancement New feature or request labels May 22, 2024
Copy link
Collaborator

@mhmd-azeez mhmd-azeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch @bradyjoslin, thanks!

@mhmd-azeez mhmd-azeez merged commit 87b4958 into extism:main May 22, 2024
1 check passed
@mhmd-azeez
Copy link
Collaborator

Released a new version:
https://github.com/extism/dotnet-pdk/releases/tag/v1.0.3

@bradyjoslin bradyjoslin deleted the patch-1 branch May 22, 2024 15:37
mhmd-azeez added a commit to extism/extism that referenced this pull request May 22, 2024
extism/dotnet-pdk#84 brought to my attention
that the Rust SDK supports both `headers` and `header` while the go sdk
only supports `headers`. After talking to Zach, we decided to remove the
`header` alias from the Rust SDK too, since it's obsolete and we want
people to use `headers`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers not being sent with Pdk.SendRequest
3 participants