Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for readonly dir mounting #68

Merged
merged 2 commits into from
Jul 25, 2024
Merged

feat: add support for readonly dir mounting #68

merged 2 commits into from
Jul 25, 2024

Conversation

mhmd-azeez
Copy link
Collaborator

No description provided.

@mhmd-azeez mhmd-azeez requested a review from zshipko July 14, 2024 15:34
@mhmd-azeez mhmd-azeez mentioned this pull request Jul 15, 2024
Merged
zshipko
zshipko approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, definitely much simpler than the Rust changes 😆

Maybe we should hold off on merging this until we can support it in Rust too?

@mhmd-azeez
Copy link
Collaborator Author

mhmd-azeez commented Jul 16, 2024 •
edited
Loading

Maybe we should hold off on merging this until we can support it in Rust too?

yeah, I agree

@mhmd-azeez mhmd-azeez merged commit 4ad86bc into main Jul 25, 2024
3 checks passed
@mhmd-azeez mhmd-azeez deleted the readonly-dir branch July 25, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshipko zshipko zshipko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhmd-azeez @zshipko