terminate() function

[brucedjones]

Allows you to terminate a running python script.

[Almenon]

I like it!

But kill alone may not suffice for exiting the script. There should be a paramater in the function that lets you send a kill signal like SIGKILL

Example: https://github.com/Almenon/AREPL-backend/blob/master/index.js#L78

Though if you kill via signal you might also want to fix the close event functionality #94

[the-freshlord]

Could this be merged anytime soon? I actually need this functionality in a project that I am working on. 😀

[brucedjones]

So I added the ability to send a kill signal. One thing that was not clear to me, was why terminate should occur if both stderr and stdout are closed, the main thing we care about is the process itself ending. So I removed that functionality as it seemed like unnecessary extra complication.

[brucedjones]

So in fixing the bugs I put the ending on stderr and stdout back in. I figured it better to be consistent with previous behavior.

[brucedjones]

@extrabacon any objections to this pull request?

[extrabacon]

Not at all, I just want to make sure I can publish shortly after merging. So sorry, too much work means I don't have time to properly handle this project.

[Almenon]

@extrabacon maybe someone could be added as a maintainer? I wouldn't mind helping out with the project. Or maybe @brucedjones?

[extrabacon]

@brucedjones + @Almenon: you are now collaborators on the repo
@brucedjones: you can also publish to NPM

[Almenon]

Thanks extrabacon. I guess I'll start out by taking a look at the unit tests. @brucedjones, want to merge in your pull request?

[Almenon]

@brucedjones I'm looking for a new maintainer to take on my duties, are you still up for it?