add : to signoff trailer (#2197)

fixes #2196
extrawurst · May 16, 2024 · fa25153 · fa25153
1 parent a92be3b
commit fa25153
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixes
 * respect configuration for remote when fetching (also applies to pulling) [[@cruessler](https://github.com/cruessler)] ([#1093](https://github.com/extrawurst/gitui/issues/1093))
+* add `:` character to sign-off trailer to comply with Conventinoal Commits standard [@semioticrobotic](https://github.com/semioticrobotic) ([#2196](https://github.com/extrawurst/gitui/issues/2196))
 
 ## [0.26.0+1] - 2024-04-14
 

diff --git a/src/popups/commit.rs b/src/popups/commit.rs
@@ -470,7 +470,7 @@ impl CommitPopup {
 		let mut msg = msg.to_owned();
 		if let (Some(user), Some(mail)) = (user, mail) {
 			msg.push_str(&format!(
-				"\n\nSigned-off-by {user} <{mail}>"
+				"\n\nSigned-off-by: {user} <{mail}>"
 			));
 		}