Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log tab shows no commits when there is 1 commit #75

Closed
alistaircarscadden opened this issue May 20, 2020 · 3 comments
Closed

Log tab shows no commits when there is 1 commit #75

alistaircarscadden opened this issue May 20, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@alistaircarscadden
Copy link
Contributor

Describe the bug
In gitui-win v0.2.6 the Log tab shows nothing when there is exactly 1 commit. When the second commit is added, both the first and second commit will appear in the Log when you go to the tab.

Furthermore, when there are 2 commits (for example "Initial commit" and "Add readme") the text in the top left of the Log tab shows "commit 0/1" instead of 2/2.

To Reproduce

  1. Create new directory and cd into it
  2. Run git init
  3. Add a file to be committed (file.txt)
  4. git add . and git commit -m "Initial commit"
  5. Run gitui and press Tab to enter the Log page

(for me, it will show there are no commits)

  1. Create another file, stage it, commit it
  2. Run gitui and press Tab to enter the Log page

(for me, it will show both commits)

Expected behavior
When there is exactly 1 commit the Log page would show it, as well as the top left text would read 'commit 1/1'

My impression would also be that the 'commit x/y' message would show y equals the total number of commits, and x equals the (1-indexed) number that is currently highlighted, where the very first commit is 1 and the most recent is >1.

Desktop (please complete the following information):
gitui-win v0.2.6

@extrawurst extrawurst added the bug Something isn't working label May 20, 2020
@extrawurst
Copy link
Owner

Hey @alistaircarscadden thanks for your interest in gitui! Indeed good catch! Should be fixed now, will roll out in the next release.

@extrawurst
Copy link
Owner

should be fixed in 0.3.0: https://github.com/extrawurst/gitui/releases/tag/v0.3.0

@alistaircarscadden
Copy link
Contributor Author

image

image

Confirmed working. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants