Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new quit key binding #771

Closed
extrawurst opened this issue Jun 5, 2021 · 2 comments
Closed

new quit key binding #771

extrawurst opened this issue Jun 5, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.16.2

Comments

@extrawurst
Copy link
Owner

Since this comes up so often my plan is to introduce a new quit_app key-binding that only reacts if no popup is open.

For reference: #770 , #766

this means:

  • in popups there is still exit_popup (ESC) to close it which allows closing text input popups that otherwise collide with q-key
  • we still have exit (CTRL+C) that exits the app no matter in what place
  • the new quit_app (Q or ESC) will close the app only when no popup is open

I am hoping to be able to cater for all the needs that where raised so far.
@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels Jun 5, 2021
@extrawurst extrawurst mentioned this issue Jun 5, 2021
Closed
@extrawurst extrawurst modified the milestones: v0.16.1, v0.17 Jun 6, 2021
@extrawurst extrawurst mentioned this issue Jun 15, 2021
Closed
@aiyoux aiyoux mentioned this issue Jun 23, 2021
Merged
silmeth added a commit to silmeth/gitui that referenced this issue Jul 15, 2021
@silmeth
vim style config: allow Q in pop-up inputs
7371824 
Change `exit` (which exits the app regardless of context) to <kbd>Ctrl</kbd>+<kbd>C</kbd>, and move <kbd>Shift</kbd>+<kbd>Q</kbd> to `quit` (which doesn’t cause quitting on upper-case `Q` insert in popup inputs, cf. extrawurst#771).
@silmeth silmeth mentioned this issue Jul 15, 2021
Merged
silmeth added a commit to silmeth/gitui that referenced this issue Jul 15, 2021
@silmeth
vim style config: allow Q in pop-up inputs
67d139a 
Change `exit` (which exits the app regardless of context) to <kbd>Ctrl</kbd>+<kbd>C</kbd> (which doesn’t cause quitting on upper-case `Q` insert in popup inputs, cf. extrawurst#771).
extrawurst pushed a commit that referenced this issue Jul 15, 2021
@silmeth
vim style config: allow Q in pop-up inputs (#818)
36e9f77 
Change `exit` (which exits the app regardless of context) to <kbd>Ctrl</kbd>+<kbd>C</kbd> (which doesn’t cause quitting on upper-case `Q` insert in popup inputs, cf. #771).
@dbr
Copy link

dbr commented Aug 3, 2021

Been using this change recently and it works really well. Thanks!

@extrawurst
Copy link
Owner Author

Been using this change recently and it works really well. Thanks!

happy to hear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.16.2
Development

No branches or pull requests
2 participants
@dbr @extrawurst