Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support commit amend #89

Closed
extrawurst opened this issue May 22, 2020 · 6 comments · Fixed by #122
Closed

support commit amend #89

extrawurst opened this issue May 22, 2020 · 6 comments · Fixed by #122
Labels
enhancement New feature or request
Milestone

Comments

@extrawurst
Copy link
Owner

extrawurst commented May 22, 2020

new command for git commit amend

before we can do that we need to land #83

@extrawurst extrawurst added the enhancement New feature or request label May 22, 2020
@MCord
Copy link
Contributor

MCord commented Jun 4, 2020

what about just adding a checkbox in the commit pop up to amend instead of committing ? many existing UI tools behave this way and this minimizes the number of commands and UI complexity.

@extrawurst
Copy link
Owner Author

I like the idea but we need to check if there is any good (cross platform) hotkey we can use that does not collide with the text input of the commit dialog (unfortunately not everything is possible in terminals and or crossterm).

@extrawurst
Copy link
Owner Author

Also I happen to know someone is working on #46 (see https://www.twitch.tv/videos/639362441) hope there is no complication touching those two issues at the same time🤞

@MCord
Copy link
Contributor

MCord commented Jun 4, 2020

what do you think about using function keys ? the stream is very cool indeed I am watching it right now !

@extrawurst
Copy link
Owner Author

extrawurst commented Jun 12, 2020

I would say let's go for the commit popup like @MCord said and add an amend option that takes the previous msg and fills it in if the current msg is empty
what about ctrl+a to hopefully not interfere with actual char inputs?

@extrawurst extrawurst added this to the 0.7 milestone Jun 12, 2020
extrawurst pushed a commit that referenced this issue Jun 12, 2020
extrawurst pushed a commit that referenced this issue Jun 12, 2020
extrawurst pushed a commit that referenced this issue Jun 12, 2020
@extrawurst
Copy link
Owner Author

this is what it looks now:
Screenflick Movie 29

extrawurst pushed a commit that referenced this issue Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants