Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed an issue with tab reverse on windows. #110

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

MCord
Copy link
Contributor

@MCord MCord commented Jun 4, 2020

This PR fixes a small but annoying bug on windows that prevents SHIFT + TAB to select the tabs in revers order. The bug is caused by the difference in interpretation of modifiers either in crossterm or lower levels.

for non windows platforms the SHIFT + TAB key generates KeyCode::BackTab without any modifiers while on windows the same produces KeyCode::BackTab + Shift modifier.

I am not sure the issue should be addressed in gitui but here is the fix.

@extrawurst
Copy link
Owner

Oh damn, we had such an issue before: #26
Can you do me a favour and tackle this upstream like I did in the previous one, the guys are more than happy to accept such fixes in crossterm.

@extrawurst extrawurst merged commit 38ee8c9 into extrawurst:master Jun 4, 2020
@MCord
Copy link
Contributor Author

MCord commented Jun 4, 2020

Sure, I will look into it.

@extrawurst
Copy link
Owner

@MCord cool I created a followup issue to keep track of this: #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants