Simplify theme overrides #1652
Merged
Simplify theme overrides #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a breaking changes entry, we did the same with key config overrides |
Done! The PR is now ready for testing, I think. |
extrawurst
reviewed
Apr 19, 2023
extrawurst
reviewed
Apr 19, 2023
|
finally had time to review. looks good, just a few questions |
cruessler
force-pushed
the
optional-theme-overwrites
branch
from
db7bc42 to
177fb10
Compare
Theme overrides are now loaded the same way key overrides are loaded. The config file, `theme.ron`, does not have to contain a complete theme anymore. Instead, it is possible to specify only the values that are supposed to override their corresponding default values.
cruessler
force-pushed
the
optional-theme-overwrites
branch
from
177fb10 to
a3e233e
Compare
but I will make these fixes after the merge |
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this pull request
Jun 4, 2024
* Simplify theme overrides Theme overrides are now loaded the same way key overrides are loaded. The config file, `theme.ron`, does not have to contain a complete theme anymore. Instead, it is possible to specify only the values that are supposed to override their corresponding default values. * Document breaking change in changelog * Test that override differs from default * Convert existing theme to patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request closes #1367.
It changes the following:
Theme overrides are now loaded the same way key overrides are loaded. The config file,
theme.ron, does not have to contain a complete theme anymore. Instead, it is possible to specify only the values that are supposed to override their corresponding default values.This PR is marked as draft because this change is breaking, and their is no automatic migration for existing configs. If that’s ok, I would extend the
Breaking Changesentry, otherwise I would add code to migrate existing themes.Update 2023-06-25: I added code for migrating existing themes to the new format.
I followed the checklist:
make checkwithout errors