Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing line break visualization #1904

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Allow customizing line break visualization #1904

merged 4 commits into from
Oct 16, 2023

Conversation

yamgent
Copy link
Contributor

@yamgent yamgent commented Sep 27, 2023

This Pull Request fixes/closes #1894.

It changes the following:

  • Add line_break to Theme.
  • Printing a line break will now consult the theme.

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@laktak laktak mentioned this pull request Sep 27, 2023
Closed
4 tasks
extrawurst
extrawurst requested changes Oct 3, 2023
View reviewed changes
Copy link
Owner

@extrawurst extrawurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is changing the way stuff is configured in themes it would be required to also mention that in THEME.md

@yamgent yamgent force-pushed the yamgent/custom-line-break branch from f2b52c5 to b9c72cb Compare October 5, 2023 00:23
@yamgent
Copy link
Contributor Author

yamgent commented Oct 5, 2023

@extrawurst updated THEME.md.

@holly-hacker holly-hacker mentioned this pull request Oct 16, 2023
Open
@extrawurst extrawurst merged commit 2fd957e into extrawurst:master Oct 16, 2023
19 checks passed
@yamgent yamgent deleted the yamgent/custom-line-break branch October 17, 2023 12:19
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
@yamgent @IndianBoy42
Allow customizing line break visualization (extrawurst#1904)
a3519bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extrawurst extrawurst extrawurst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make diff line-break visualisation "¶" optional
2 participants
@yamgent @extrawurst