Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unsigned tagging #1915

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

TeFiLeDo
Copy link
Contributor

@TeFiLeDo TeFiLeDo commented Oct 9, 2023

This Pull Request fixes/closes no existing issue. Do I need to open one? Can I just link this PR in the change log?

It changes the following:

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

src/components/tag_commit.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@extrawurst
Copy link
Owner

There is a merge conflict

@TeFiLeDo
Copy link
Contributor Author

Not anymore

@extrawurst extrawurst merged commit 2be0e73 into extrawurst:master Oct 17, 2023
19 checks passed
@extrawurst
Copy link
Owner

extrawurst commented Oct 17, 2023

thanks ❤️

IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
* prevent creation of tags when tag-signing is configured

Co-authored-by: extrawurst <776816+extrawurst@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants