Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git2::DiffLineType enum instead of char values (#655) #668

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

wandernauta
Copy link
Contributor

@wandernauta wandernauta commented Apr 25, 2021

The DiffLineType enum in asyncgit has fewer variants: it maps context lines and
line types we don't expect to None. This behavior is kept unchanged.

Now calls .origin_value() rather than .origin() except in one debug log.

closes #655

The DiffLineType enum in asyncgit has fewer variants: it maps context lines and
line types we don't expect to None. This behavior is kept unchanged.

Now calls `.origin_value()` rather than `.origin()` except in one debug log.
@extrawurst extrawurst merged commit c42d369 into extrawurst:master Apr 25, 2021
@extrawurst
Copy link
Owner

@wandernauta welcome and thank you for this contribution ❤️

extrawurst pushed a commit that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup some stringly typed code
2 participants