graphQL integration testing #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 6, 2023 18:06
# Conflicts: # .gitignore
# Conflicts: # src/main/java/com/solvd/micro9/users/domain/elasticsearch/ESearchUser.java # src/test/java/com/solvd/micro9/users/TestUtils.java
h1alexbel
requested changes
Jun 15, 2023
| @Test | ||
| void verifyUsersAreFondByCriteriaTest() { | ||
| int size = 10; | ||
| String query = "{ findByCriteria (criteria: {name: \"a\"}, size: " + size |
There was a problem hiding this comment.
@eyakauleva you can use formatted() from java.lang.String
| import java.util.stream.IntStream; | ||
|
|
||
| @GraphQlTest(GraphqlUserController.class) | ||
| @Import(GraphQLITConfig.class) |
There was a problem hiding this comment.
@eyakauleva you have naming inconsistency, I mean GraphqlUserController vs GraphQLITConfig
| @Autowired | ||
| private UserProducer producer; | ||
|
|
||
| @Test | ||
| @SneakyThrows |
There was a problem hiding this comment.
@eyakauleva try-catch is bad idea in tests
it's better to use throws keyword inside your tests
|
|
||
| @GraphQlTest(GraphqlUserController.class) | ||
| @Import(GraphQLITConfig.class) | ||
| public class GraphQLIT { |
There was a problem hiding this comment.
I think you can rename this class to GraphqlUserControllerIT or GraphqlUserControllerITCase
Repository owner
deleted a comment from
codecov-commenter
Jun 17, 2023
Repository owner
deleted a comment from
codecov-commenter
Jun 17, 2023
h1alexbel
reviewed
Jun 20, 2023
| } | ||
|
|
||
| @Test | ||
| void verifyUsersAreFondByCriteriaTest() { |
There was a problem hiding this comment.
@eyakauleva In JUnit 5, It's not necessary, to add suffix Test to the method's signature
Repository owner
deleted a comment from
codecov-commenter
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.