Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leftover warning regarding validate_all_dimensions_compatibility not being used #569

Closed
eyalroz opened this issue Jan 6, 2024 · 0 comments
Closed

Leftover warning regarding validate_all_dimensions_compatibility not being used #569

eyalroz opened this issue Jan 6, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jan 6, 2024 •
edited
Loading

Our use of validate_all_dimensions_compatibility(), realized in the fix for #561, only occurs in debug mode (when NDEBUG is undefined); but I forgot to surround the definition of this function itself with #ifndef NDEBUG, so we still get a warning message in release mode.
@eyalroz eyalroz added the task label Jan 6, 2024
@eyalroz eyalroz self-assigned this Jan 6, 2024
eyalroz added a commit that referenced this issue Jan 6, 2024
@eyalroz
Fixes #569: Avoiding a compiler warning in release mode by only defin…
9e5ebaf 
…ing `validate_all_dimensions_compatibility()` when `NDEBUG` is undefined
@eyalroz eyalroz closed this as completed in cbef9b3 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz