Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve launch configuration validation #582

Closed
eyalroz opened this issue Feb 5, 2024 · 0 comments
Closed

Improve launch configuration validation #582

eyalroz opened this issue Feb 5, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Feb 5, 2024

Let's:

  1. Make sure that all kernel launch functions try to validate - in Debug mode - their launch configurations, in themselves and w.r.t. the relevant device and/or kernel.
  2. We're not currently doing any validation w.r.t. block cooperation support and CUDA-12 launch attributes. Let's start doing that.
@eyalroz eyalroz added the task label Feb 5, 2024
@eyalroz eyalroz self-assigned this Feb 5, 2024
eyalroz added a commit that referenced this issue Feb 5, 2024
@eyalroz
Fixes #582:
440639c 
* launch config <-> device validation now checks for block cooperation support when that's requested
* Refactored and re-located some of the launch config validation code
* Made sure the code paths inwards from the non-detail_ launching functions to the actual CUDA API calls all have appropriate validation calls
* Comment and spacing tweaks
eyalroz added a commit that referenced this issue Feb 9, 2024
@eyalroz
Fixes #582:
7f35ae4 
* launch config <-> device validation now checks for block cooperation support when that's requested
* Refactored and re-located some of the launch config validation code
* Added: `device_t` method for checking block cooperation support
* Now properly validating grid dimensions to ensure we don't exceed the maxima
* Made sure the code paths inwards from the non-detail_ launching functions to the actual CUDA API calls all have appropriate validation calls
* Comment and spacing tweaks
eyalroz added a commit that referenced this issue Feb 9, 2024
@eyalroz
Fixes #582, fixes #564:
db7a03e 
* launch config <-> device validation now checks for block cooperation support when that's requested
* Refactored and re-located some of the launch config validation code
* Added: `device_t` method for checking block cooperation support
* Now properly validating grid dimensions to ensure we don't exceed the maxima
* Made sure the code paths inwards from the non-detail_ launching functions to the actual CUDA API calls all have appropriate validation calls
* Comment and spacing tweaks
eyalroz added a commit that referenced this issue Feb 9, 2024
@eyalroz
Fixes #582, fixes #564:
410c7d0 
* launch config <-> device validation now checks for block cooperation support when that's requested
* Refactored and re-located some of the launch config validation code
* Added: `device_t` method for checking block cooperation support
* Now properly validating grid dimensions to ensure we don't exceed the maxima
* Made sure the code paths inwards from the non-detail_ launching functions to the actual CUDA API calls all have appropriate validation calls
* Comment and spacing tweaks
eyalroz added a commit that referenced this issue Feb 10, 2024
@eyalroz
Fixes #582, fixes #564:
78f30f6 
* launch config <-> device validation now checks for block cooperation support when that's requested
* Refactored and re-located some of the launch config validation code
* Added: `device_t` method for checking block cooperation support
* Now properly validating grid dimensions to ensure we don't exceed the maxima
* Made sure the code paths inwards from the non-detail_ launching functions to the actual CUDA API calls all have appropriate validation calls
* In the error_handling example - now making the faulty launch configuration device-specific, otherwise we don't apply the valid-block-size limit
* Comment and spacing tweaks
eyalroz added a commit that referenced this issue Feb 29, 2024
@eyalroz
Fixes #582, fixes #564:
29c5672 
* launch config <-> device validation now checks for block cooperation support when that's requested
* Refactored and re-located some of the launch config validation code
* Added: `device_t` method for checking block cooperation support
* Now properly validating grid dimensions to ensure we don't exceed the maxima
* Made sure the code paths inwards from the non-detail_ launching functions to the actual CUDA API calls all have appropriate validation calls
* In the error_handling example - now making the faulty launch configuration device-specific, otherwise we don't apply the valid-block-size limit
* Comment and spacing tweaks
@eyalroz eyalroz closed this as completed in 5b0e27f Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz