We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I've asked for a code review of my unique_span class, on codereviews.stackexchange.com, and got one.
Issues brought up:
swap()
T
release()
noexcept
Well, my decision about all of those:
{}
The text was updated successfully, but these errors were encountered:
Fixes #665: Addressed unique_span code review issues.
d8f8432
4301b7e
Some issues can't be fully addressed due to the use of the "poor man's span" with earlier C++ versions, as the base class.
Sorry, something went wrong.
eyalroz
No branches or pull requests
I've asked for a code review of my unique_span class, on codereviews.stackexchange.com, and got one.
Issues brought up:
swap()
T
to a span of constT
.release()
isnoexcept
... so making any of our [move] constructorsnoexcept
is a leap of faith.Well, my decision about all of those:
{}
is a bit confusing for the reader, IMHO, so let's keep that part explicit.edit: see Change unique_span to take a deleter object taking a span, not a template param accepting taking pointer #678 .
The text was updated successfully, but these errors were encountered: