Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename macro to be less-clashy #671

Open
eyalroz opened this issue Sep 5, 2024 · 0 comments
Open

Rename macro to be less-clashy #671

eyalroz opened this issue Sep 5, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Sep 5, 2024

We currently define a macro named CAN_GET_APRIORI_KERNEL_HANDLE in our headers. While that's not a very likely name to clash, let's be nice and prefix that with CAW_, to be extra safe.
@eyalroz eyalroz added the task label Sep 5, 2024
@eyalroz eyalroz self-assigned this Sep 5, 2024
eyalroz added a commit that referenced this issue Sep 5, 2024
@eyalroz
Fixes #671: Renamed a macro: CAN_GET_APRIORI_KERNEL_HANDLE -> `CAW_…
c8e14f9 
…CAN_GET_APRIORI_KERNEL_HANDLE`
eyalroz added a commit that referenced this issue Sep 5, 2024
@eyalroz
Regards #671: Dropped gratuitous and weird setting of kernel launch n…
e03500c 
…ode parameters in a graph instance, in `simpleCudaGraphs`
eyalroz added a commit that referenced this issue Sep 5, 2024
@eyalroz
Fixes #671: Can now get a kernel's module using its handle
1c00758
eyalroz added a commit that referenced this issue Sep 5, 2024
@eyalroz
Fixes #671: Renamed a macro: CAN_GET_APRIORI_KERNEL_HANDLE -> `CAW_…
641e074 
…CAN_GET_APRIORI_KERNEL_HANDLE`
eyalroz added a commit that referenced this issue Sep 5, 2024
@eyalroz
Fixes #671: Can now get a kernel's module using its handle
4b8164f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz