Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Dynamically link libgit2.so #214

Closed
kpcyrd opened this issue Sep 7, 2023 · 2 comments · Fixed by #233
Closed

feat: Dynamically link libgit2.so #214

kpcyrd opened this issue Sep 7, 2023 · 2 comments · Fixed by #233
Labels
dependencies Pull requests that update a dependency file features › git packaging › deb

Comments

@kpcyrd
Copy link
Contributor

kpcyrd commented Sep 7, 2023

hi!

The Cargo.toml currently enables the vendored-libgit2 feature unconditionally, I think this should default to off with an option to enable it (similar to the vendored-openssl feature that can optionally be enabled).

Thanks!
@cafkafk
Copy link
Member

cafkafk commented Sep 7, 2023

Yes, this was introduced in #192 to ease packaging for debian/ubuntu. Perhaps @gierens can enable do this and enable the feature in the deb repository?

@PThorpe92 PThorpe92 added dependencies Pull requests that update a dependency file features › git packaging › deb labels Sep 7, 2023
@gierens gierens mentioned this issue Sep 9, 2023
Merged
@kpcyrd
Copy link
Contributor Author

kpcyrd commented Sep 9, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file features › git packaging › deb
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose vendored libgit2 gierens/eza
3 participants
@kpcyrd @cafkafk @PThorpe92