Add vendored-libgit2 feature to git2 dependency #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds libgit2 into the binary to avoid dependency problems on systems that don't have the required version of libgit2 yet. Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
gierens
added
dependencies
Refs: eza-community#192 Signed-off-by: Christina Sørensen <christina@cafkafk.com>
cafkafk
approved these changes
Sep 4, 2023
Omnikron13
pushed a commit
to Omnikron13/eza
that referenced
this pull request
Mar 17, 2024
Refs: eza-community#192 Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds libgit2 into the binary to avoid dependency problems on systems that don't have the required version of libgit2 yet.
Background:
When building the deb package from eza tag v0.11.0 and installing it you run into this problem:
I'm not exactly sure why this didn't appear before and how we got into this, but my best guess is this #182 where be bumped the https://github.com/rust-lang/git2-rs/ version. Somehow the new version requires the
vendored-libgit2feature to be set to ship libgit2 with it and before it didn't, although I can't really tell where from their changelog.You might wonder why don't we just add this as dependency to our deb package ... well, neither the newest Ubuntu nor Debian have the required libgit2 v1.7 in their repos but only v1.1 or v1.5.