(exa PR) 1100: Adding more icons - change default icon for videos and PHP #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafkafk
commented
Jul 30, 2023
| m.insert("config.m4", '\u{e615}'); // | ||
| m.insert("config.mk", '\u{e615}'); // | ||
| m.insert("configure", '\u{f489}'); // | ||
| m.insert("contributing", '\u{e60a}'); // |
There was a problem hiding this comment.
Not very useful in my opinion since a lot of contributing files are .md or the like, so since the icon is bad may remove it? Worst case we can still add a better one later
| m.insert("docker-compose.yml", '\u{f308}'); // | ||
| m.insert("Dockerfile", '\u{f308}'); // | ||
| m.insert("Documents", '\u{f02d}'); // |
There was a problem hiding this comment.
I honestly don’t really the idea of having my personal folders icons change, and only if I name them in English.
|
I feel like these should be squashed and commit messages should be improved, e.g. "sorry" is very nice but not very descriptive. |
cafkafk
changed the title
This is a combination of 8 commits. Subjective icon changes, more extensions, more names More icons Fix video icon, more /etc Added GPG and KBX icons Disk image formats Added Pictures, Music, Documents Sorry
|
This pull request is stale because it has been open for 30 days with no activity. |
|
Closed in favor of #224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ogham/exa#1100