Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(exa PR) 1051: changed default folder icon #46

Merged
merged 1 commit into from
Jul 30, 2023
Merged

(exa PR) 1051: changed default folder icon #46

merged 1 commit into from
Jul 30, 2023

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jul 29, 2023 •
edited
Loading

@cafkafk cafkafk changed the title (exa PR) 1051 (exa PR) 1051: changed default folder icon Jul 29, 2023
sbatial
sbatial reviewed Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@sbatial sbatial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't care at the end of the day but would argue that an open folder makes more sense as the files inside the folder are (usually) shown

@cafkafk
Copy link
Member Author

cafkafk commented Jul 30, 2023

i don't care at the end of the day but would argue that an open folder makes more sense as the files inside the folder are (usually) shown

That's the default behavior that this changes right? I can't actually see the icon this wants to change too, can you e.g. add a screenshot?

@sbatial
Copy link
Collaborator

sbatial commented Jul 30, 2023

image

Here's a side-by-side (or top-by-bottom rather?!)

@sbatial
Copy link
Collaborator

sbatial commented Jul 30, 2023

I kinda like both.
It would be nice to have them actually indicate folders which are recursed into... But I don't know how much work that'll be and is not in the scope of this PR

@cafkafk
Copy link
Member Author

cafkafk commented Jul 30, 2023

I kinda like both. It would be nice to have them actually indicate folders which are recursed into

I guess in that case this PR would be the default, so it makes sense to merge and e.g. create an issue for that (it's a good idea imo)

@sbatial sbatial mentioned this pull request Jul 30, 2023
Closed
sbatial
sbatial approved these changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@sbatial sbatial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good default.
See #92 for follow-up

@cafkafk cafkafk merged commit f69e9e2 into main Jul 30, 2023
@sbatial sbatial deleted the pr-1051 branch July 30, 2023 13:07
@sbatial sbatial mentioned this pull request Jul 30, 2023
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbatial sbatial sbatial approved these changes

Assignees
No one assigned
Labels
features › icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cafkafk @sbatial @CT-66