Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display offset for filenames with spaces #548

Closed
wants to merge 0 commits into from

Conversation

guillaumeboehm
Copy link
Contributor

Fix for #547

I did the fix somewhat quickly so I might have broken something else.
If I missed something please give me a little bit of context and I'll fix it!

Copy link
Member

@PThorpe92 PThorpe92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

Yeah this seems to fix it. I generated some pretty ridiculous file names with many spaces and it seemed to solve the problem.
I'm gonna work on test cases for it.

@cafkafk I think perhaps we need some nix tests with 'spaces in filenames'.json

I'll generate some later and test this PR against it.

src/output/grid.rs Outdated Show resolved Hide resolved
@guillaumeboehm
Copy link
Contributor Author

Renamed to "offset" and fixed the display for the hyperlink option as well.

@guillaumeboehm
Copy link
Contributor Author

Felt like a bit more clarity wouldn't hurt.

@PThorpe92
Copy link
Member

Oh my bad.. totally didn't mean to close this. I was just fixing the rustfmt issue in the build. for some reason it closed the PR.

Definitely open a new one lol my fault ❤️

@PThorpe92
Copy link
Member

PThorpe92 commented Oct 20, 2023

reopening..

EDIT: yeah it's not letting me re-open this. Something similar happened for a PR I had in here a while ago. It will let me edit it on github, but if I make changes from my local machine and push to your fork, it auto-closes the PR and wont let me open it again. My fault

@guillaumeboehm
Copy link
Contributor Author

reopening..

EDIT: yeah it's not letting me re-open this. Something similar happened for a PR I had in here a while ago. It will let me edit it on github, but if I make changes from my local machine and push to your fork, it auto-closes the PR and wont let me open it again. My fault

Wait I'm so confused xD should I open a new PR ?

@PThorpe92
Copy link
Member

Lol yeah at first i thought i could re-open this one. You did the right thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants