Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downsample #126

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix downsample #126

merged 1 commit into from
Jun 11, 2024

Conversation

cboulay
Copy link
Collaborator

@cboulay cboulay commented Jun 9, 2024 •
edited
Loading

  • New unit tests for core (generator function) processing
  • accommodate size-0 arrays
  • when there is no output, return size-0 arrays instead of None
  • slight optim. using template struct -- this approach is abandoned in a future PR so don't dwell on it.

ETA:
This also fixes a bug! Prior to this PR, the downsample generator would not make proper copies and would overwrite shared fields in long-passed messages.

@cboulay
Upgrade downsample
1949473 
* faster unit tests on core processing
* accommodate size-0 arrays
* slight optim. using template struct.
@cboulay
Copy link
Collaborator Author

cboulay commented Jun 9, 2024 •
edited
Loading

Because this fixes a bug that I created, I'm inclined to go ahead and merge this myself.
However, the bug is fairly low priority because it only affects people who were using downsample generator, outside the ez.run() context (which did deepcopy on each msg), so I'll wait 24 hrs for objections.

@pperanich pperanich merged commit 326e1b1 into dev Jun 11, 2024
@cboulay cboulay deleted the cboulay/fix_downsample branch June 13, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cboulay @pperanich