Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): _.merge doesn't concat arrays #314

Merged
merged 1 commit into from
May 4, 2022

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented May 3, 2022

Summary

Small change to the docs to fix a reference to how _.merge deep merges work with arrays

Details

References

Will be closing out #226 after this as it duplicates #86 otherwise

  • I would've made this PR like 2 years ago to fix the docs, but unfortunately when randos on the internet are abusive to you because they only believe in their own opinion and then don't contribute anything anyway, it is not very motivational, to say the absolute least 😕 (see also my current status)

- it's a deep merge that merges them by index
- the rest of the docs are accurate, just this one mention was incorrect

- eventually should move to shallow merge/replace arrays to better
  reflect how `tsconfig` `extends` works, but just fix the docs for now
@agilgur5 agilgur5 added the scope: docs Documentation could be improved. Or changes that only affect docs label May 3, 2022
@ezolenko ezolenko merged commit e4b5880 into ezolenko:master May 4, 2022
@agilgur5 agilgur5 added the kind: bug Something isn't working properly label Jul 22, 2022
@agilgur5 agilgur5 added the kind: dx Improvements to dev experience, e.g. error messages, logging, external-facing docs, etc label Sep 4, 2022
@agilgur5 agilgur5 deleted the fix-docs-merge-no-concat branch July 2, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working properly kind: dx Improvements to dev experience, e.g. error messages, logging, external-facing docs, etc scope: docs Documentation could be improved. Or changes that only affect docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants