Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optim(ci): use npm ci for install and cache npm #323

Merged
merged 1 commit into from
May 10, 2022

Conversation

agilgur5
Copy link
Collaborator

Summary

Optimize CI by using npm ci and caching npm installs

Details

- `npm ci` is installation for, well, CI, and is a good bit faster
  - c.f. https://docs.npmjs.com/cli/v8/commands/npm-ci

- cache `npm` installation with `setup-node` for speedier installs
  - upgrade `setup-node` as this was released in v2.2.0:
    https://github.com/actions/setup-node/releases/tag/v2.2.0
@agilgur5 agilgur5 added kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs kind: optimization Performance, space, size, etc improvement labels May 10, 2022
@agilgur5
Copy link
Collaborator Author

agilgur5 commented May 10, 2022

Hard to tell from just a single CI run, but looks ~25% faster (basically installation is twice as fast). And there's no cache on this run just yet!

@ezolenko ezolenko merged commit 327574e into ezolenko:master May 10, 2022
@agilgur5 agilgur5 deleted the optim-ci-cache branch July 2, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs kind: optimization Performance, space, size, etc improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants