fix: don't duplicate type-only check on Windows #385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that the type-only / "missed" type-check doesn't duplicate on Windows
include
d files missed bytransform
(type-only files) #345 (comment) and the currently failing CI onmaster
Details
gotta remember to normalize file names 🙃
refactor: improve normalization in
errors.spec
local
, instead of just oneReview Notes
I confirmed on CI on my fork that tests pass on Windows now