-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: back to using vue.d.ts
instead of .d.ts
for Vue declarations
#410
Conversation
This reverts commit e145d0b. - Per discussion on the original issue and reverted PR, it seems that the request to use `.d.ts` instead of `.vue.d.ts` was made in error - `.d.ts` seems to only be necessary if Vue users were importing `.vue` SFCs without extensions ("extensionless") - i.e. `import MyComponent from "./MyComponent"` instead of `import MyComponent from "./MyComponent.vue"` - and "extensionless" imports are no longer supported by the Vue team (but used to be) - requiring extensionless imports also breaks imports when extensions _are_ used - so these are not necessarily compatible with each other, but the Vue team support strongly suggests that `.vue.d.ts` would be the proper way forward
Yeah, we should support official way of importing, so looks good. Do we want to release this sooner than later? Any other PRs you want to include (or exclude)? |
So depends if we're considering this as a breaking change or not. Exclude-wise, I was just thinking of leaving #406 until either The rest of my PRs in the queue should not affect the release one way or another as they're only testing changes, clean-up, or refactors; i.e. no functional changes to the plugin itself. |
I think we should do 0.33 then without #406, and then 0.34 with that when it is ready |
Ok, up to you 👍 Your releases consistently err on the side of breaking (vs. patch), so that's maybe more expected for rpt2 users too, in that sense.
Thanks for (mostly) copying my release notes style!
I also saw that the |
I basically took autogenerated release notes with your commit messages and rearranged them to hide internal stuff, so those are literally your release notes. :) Yeah, forgot to push local branch with build commit before tagging on github :/ |
Yep that's the basic gist of the structure I use 👍 plus a few manual things where explanations could be helpful
Yea I've done that multiple times before too 😅 If you're interested, we can also automate the release process with GH Actions too |
This reverts commit e145d0b / PR #336
NOTE: this may be considered breaking, so we may want to release this in a breaking release as such. I've left this PR as draft as such. That being said, this could also be considered as just a bugfix as the original PR was made in error and caused a bug.
Summary
Revert back to using
.vue.d.ts
for Vue declarationsDetails
.d.ts
instead of.vue.d.ts
was made in error.d.ts
seems to only be necessary if Vue users were importing.vue
SFCs without extensions ("extensionless")import MyComponent from "./MyComponent"
instead ofimport MyComponent from "./MyComponent.vue"
.vue.d.ts
would be the proper way forwardCredits
Thanks to @andrew0 for finding this problem and providing evidence 🙂