Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switching from tslint (deprecated) to eslint #463

Merged
merged 5 commits into from
Sep 26, 2023
Merged

switching from tslint (deprecated) to eslint #463

merged 5 commits into from
Sep 26, 2023

Conversation

ezolenko
Copy link
Owner

Summary

tslint is deprecated and now started to produce errors with new typescript

Details

Switching to typescript-eslint

agilgur5
agilgur5 reviewed Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick glance through as I happened to already be on GH and got a notification

package.json Outdated Show resolved Hide resolved
.eslintrc.cjs Outdated Show resolved Hide resolved
.eslintrc.cjs Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@agilgur5 agilgur5 added the scope: dependencies Issues or PRs about updating a dependency label Sep 26, 2023
ezolenko and others added 3 commits September 25, 2023 23:43
@ezolenko @agilgur5
Update package.json
6f0146d 
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
@ezolenko
- updates for review
6a464e8
@ezolenko
- reverting find-cache-dir because it breaks tsjest
2a7e5b3
agilgur5
agilgur5 reviewed Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like CI is passing now -- a few formatting things + a comment, otherwise LGTM

rollup.config.base.js Outdated Show resolved Hide resolved
.eslintrc.cjs Outdated Show resolved Hide resolved
.eslintrc.cjs Outdated Show resolved Hide resolved
.eslintrc.cjs Show resolved Hide resolved
@ezolenko @agilgur5
Apply suggestions from code review
80fc556 
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
agilgur5
agilgur5 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this!

@agilgur5 agilgur5 added the kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs label Sep 26, 2023
@ezolenko ezolenko merged commit 592ed5c into master Sep 26, 2023
6 checks passed
@agilgur5 agilgur5 deleted the eslint branch September 26, 2023 16:20
@agilgur5 agilgur5 mentioned this pull request Nov 7, 2023
Merged
@agilgur5 agilgur5 mentioned this pull request Jan 6, 2024
Merged
@paaschdigital paaschdigital mentioned this pull request May 20, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 21, 2024
Open
@bamboo5-dot bamboo5-dot mentioned this pull request May 30, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Jun 5, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Jun 6, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 7, 2024
Open
@OATEF4313 OATEF4313 mentioned this pull request Jun 20, 2024
Open
@mohammad-84 mohammad-84 mentioned this pull request Jun 22, 2024
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 2, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 2, 2024
Closed
@tahabiyikli tahabiyikli mentioned this pull request Jul 12, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 17, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Jul 17, 2024
Open
@NOUIY NOUIY mentioned this pull request Jul 20, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Aug 24, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Aug 24, 2024
Open
@opekeye opekeye mentioned this pull request Aug 27, 2024
Open
@NOUIY NOUIY mentioned this pull request Aug 31, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Sep 7, 2024
Open
@NOUIY NOUIY mentioned this pull request Sep 9, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Sep 11, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 12, 2024
Open
@organich organich mentioned this pull request Sep 13, 2024
Open
@Zionsammy Zionsammy mentioned this pull request Sep 21, 2024
Open
@timscharfenort8 timscharfenort8 mentioned this pull request Oct 3, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Nov 2, 2024
Open
@NOUIY NOUIY mentioned this pull request Nov 2, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: dependencies Issues or PRs about updating a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezolenko @agilgur5