Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization] Skip loading user and path if not needed #171

Merged
merged 2 commits into from
May 14, 2019

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented May 3, 2019

Some optimizations to reduce default Repo lookups by bridge from 11 to 3 cache lookups , this also avoids the serialization and mapping of these objects to API objects and logic around that.

@andrerom andrerom requested a review from emodric May 3, 2019 06:15
Copy link
Collaborator

@emodric emodric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm on vacation, I'll have to test these, not just visual, when I come back, next week :)

@andrerom
Copy link
Contributor Author

@emodric Can you review this despite the Travis PHP 5.6 proc_open() failure?

Copy link
Collaborator

@emodric emodric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, although, I only tested on 2.x by manually merging.

@andrerom andrerom merged commit af192de into 1.5 May 14, 2019
@andrerom andrerom deleted the optimize_bridge_db_loading branch May 14, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants