Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add option to Init to inject basic INI settings #172

Merged
merged 7 commits into from
May 14, 2019
Merged

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented May 3, 2019

Basic settings to simplify testing legacy / bridge on a eZ Platform install.
Config here aligns with what is in clean eZ Platform install, and adds a legacy_admin siteaccess to access legacy admin.

The generated ini contains debug and development settings so it's easy to switch them on if needed.

@andrerom andrerom requested a review from emodric May 3, 2019 06:34
@andrerom andrerom changed the title [Feature] Add option to Init to inject basic INI settings needed [Feature] Add option to Init to inject basic INI settings May 3, 2019
AdditionalSiteDesignList[]=base

[RegionalSettings]
Locale=eng-GB
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could in theory make this a Twig template and inject the correct values taken from Symfony container. Same goes for the list of siteaccesses.

Similar to this: https://github.com/netgen/NetgenAdminUIBundle/blob/master/bundle/Installer/_templates/legacy_siteaccess/site.ini.append.php#L23

Copy link
Contributor Author

@andrerom andrerom May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally yes.

Is that something you'd be able to contribute here? (the code involved in the "rendering" and saving of the results of the ini templates)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could, but next only next week 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emodric can we do this as a followup? Given this is meant to be used for testing use cases straight after clean install, and atm clean install still is limited to eng-GB, this is imho ok for a start.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emodric I'm unable to figure out the proc_open issue on PHP 5.6 omn Travis, could you review this regardless of 5.6 failure?

@andrerom andrerom requested review from glye and vidarl May 11, 2019 12:31
@andrerom andrerom force-pushed the generate_ini branch 8 times, most recently from bf26e60 to 887fe6e Compare May 14, 2019 05:55
@andrerom andrerom merged commit 3218975 into 1.5 May 14, 2019
@andrerom andrerom deleted the generate_ini branch May 14, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants