-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add option to Init to inject basic INI settings #172
Conversation
bundle/Resources/init_ini/siteaccess/legacy_admin/site.ini.append.php
Outdated
Show resolved
Hide resolved
AdditionalSiteDesignList[]=base | ||
|
||
[RegionalSettings] | ||
Locale=eng-GB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could in theory make this a Twig template and inject the correct values taken from Symfony container. Same goes for the list of siteaccesses.
Similar to this: https://github.com/netgen/NetgenAdminUIBundle/blob/master/bundle/Installer/_templates/legacy_siteaccess/site.ini.append.php#L23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally yes.
Is that something you'd be able to contribute here? (the code involved in the "rendering" and saving of the results of the ini templates)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could, but next only next week 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emodric can we do this as a followup? Given this is meant to be used for testing use cases straight after clean install, and atm clean install still is limited to eng-GB, this is imho ok for a start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, no problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emodric I'm unable to figure out the proc_open issue on PHP 5.6 omn Travis, could you review this regardless of 5.6 failure?
bf26e60
to
887fe6e
Compare
Basic settings to simplify testing legacy / bridge on a eZ Platform install.
Config here aligns with what is in clean eZ Platform install, and adds a
legacy_admin
siteaccess to access legacy admin.The generated ini contains debug and development settings so it's easy to switch them on if needed.