Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2103: Bumped tedivm/stash requirement #3

Merged
merged 2 commits into from
May 31, 2022
Merged

IBX-2103: Bumped tedivm/stash requirement #3

merged 2 commits into from
May 31, 2022

Conversation

mateuszdebinski
Copy link

@mateuszdebinski mateuszdebinski added the bug Something isn't working label May 17, 2022
@mateuszdebinski mateuszdebinski requested a review from a team May 17, 2022 10:15
@mateuszdebinski mateuszdebinski self-assigned this May 17, 2022
@konradoboza
Copy link
Member

This is a potential BC break, yet I cannot see any breaking changes coming from the 0.17.0 (nor 0.17.1 which is the latest at the moment) release https://github.com/tedious/Stash/releases/tag/v0.17.0. Have you performed any basic sanities at least?

@konradoboza konradoboza requested a review from webhdx May 19, 2022 10:23
konradoboza
konradoboza approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@konradoboza konradoboza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After internal sync and based on my previous comment, I think we should be good with this change, yet sanities would be welcome anyway.

@konradoboza konradoboza requested a review from a team May 19, 2022 10:40
webhdx
webhdx approved these changes May 19, 2022
View reviewed changes
Copy link

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 though this is indeed a BC break. This has to be clearly stated in upgrade guide.

This was referenced May 20, 2022
Closed
Closed
Closed
@micszo micszo self-assigned this May 20, 2022
micszo
micszo approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced and retested on Ibexa DXP v3.3.19 with Stash v0.17.1.

@micszo micszo removed their assignment May 20, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@webhdx webhdx merged commit f3ec371 into master May 31, 2022
@webhdx webhdx deleted the IBX-2103_bump-tedious-stash-requirement branch May 31, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@micszo micszo micszo approved these changes

@webhdx webhdx webhdx approved these changes

@damianz5 damianz5 damianz5 approved these changes

Assignees

@mateuszdebinski mateuszdebinski

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mateuszdebinski @konradoboza @damianz5 @webhdx @micszo